Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add missing pending cops #1634

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Add missing pending cops #1634

merged 1 commit into from
Apr 25, 2023

Conversation

pirj
Copy link
Member

@pirj pirj commented Apr 25, 2023 •
edited
Loading

If you have created a new cop:

  • The cop is configured as Enabled: true in .rubocop.yml.
  • The cop is configured as Enabled: true in .rubocop.yml.
  • The cop is configured as Enabled: true in .rubocop.yml.

Is it worth adding an automated check not to miss out next time?

@pirj pirj self-assigned this Apr 25, 2023
@pirj pirj requested a review from bquorning April 25, 2023 19:57
bquorning
bquorning approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bquorning bquorning merged commit 70a97b1 into master Apr 25, 2023
@bquorning bquorning deleted the internally-enable-pending-cops branch April 25, 2023 20:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bquorning bquorning bquorning approved these changes

Assignees

@pirj pirj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pirj @bquorning