Merge pull request #10567 from koic/fix_a_false_positive_for_lint_amb…

…iguous_block_association

[Fix #10566] Fix a falase positive for `Lint/AmbiguousBlockAssociation`

changelog/fix_a_false_positive_for_lint_ambiguous_block_association.md

@@ -0,0 +1 @@
+* [#10566](https://github.com/rubocop/rubocop/issues/10566): Fix a false positive for `Lint/AmbiguousBlockAssociation` when using proc is used as a last argument. ([@koic][])

lib/rubocop/cop/lint/ambiguous_block_association.rb

@@ -44,7 +44,8 @@ def on_send(node)
           return unless node.arguments?
 
           return unless ambiguous_block_association?(node)
-          return if node.parenthesized? || node.last_argument.lambda? || allowed_method?(node)
+          return if node.parenthesized? || node.last_argument.lambda? || node.last_argument.proc? ||
+                    allowed_method?(node)
 
           message = message(node)
 

spec/rubocop/cop/lint/ambiguous_block_association_spec.rb

@@ -22,6 +22,8 @@
   it_behaves_like 'accepts', 'Proc.new { puts "proc" }'
   it_behaves_like 'accepts', 'expect { order.save }.to(change { orders.size })'
   it_behaves_like 'accepts', 'scope :active, -> { where(status: "active") }'
+  it_behaves_like 'accepts', 'scope :active, proc { where(status: "active") }'
+  it_behaves_like 'accepts', 'scope :active, Proc.new { where(status: "active") }'
   it_behaves_like('accepts', 'assert_equal posts.find { |p| p.title == "Foo" }, results.first')
   it_behaves_like('accepts', 'assert_equal(posts.find { |p| p.title == "Foo" }, results.first)')
   it_behaves_like('accepts', 'assert_equal(results.first, posts.find { |p| p.title == "Foo" })')