Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use American English #262

Closed
agrimm opened this issue Jan 13, 2014 · 4 comments
Closed

Use American English #262

agrimm opened this issue Jan 13, 2014 · 4 comments

Comments

@agrimm
Copy link

agrimm commented Jan 13, 2014

If non-English languages should be avoided in code, should non-American English be avoided as well?

I think this makes sense, but I haven't done coding in a group of people, so I don't know what other people think.

# bad
attr_accessor :colour

# good
attr_accessor :color

See also rubocop/rubocop#700

@bbatsov
Copy link
Collaborator

bbatsov commented Jan 14, 2014

I guess so.

@andyw8
Copy link
Contributor

andyw8 commented Sep 13, 2014

+1

@freemanoid
Copy link

My opinion is that this is not ruby-specific codestyle rule, it's more like a common rule for any programming language so this guide isn't a right place for that.
Moreover I think that these rules can be omitted as well https://github.com/bbatsov/ruby-style-guide#english-identifiers https://github.com/bbatsov/ruby-style-guide#english-comments

@andyw8
Copy link
Contributor

andyw8 commented Sep 13, 2014

That's a good point. I withdraw my +1.

@bbatsov bbatsov closed this as completed Jan 2, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants