Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

增加精华帖连接 #1032

Merged
merged 2 commits into from
May 9, 2018
Merged

增加精华帖连接 #1032

merged 2 commits into from
May 9, 2018

Conversation

jicheng1014
Copy link
Contributor

修改 优质帖子 与 精华帖 在 icon 上相同引起的误解

修改 优质帖子 与 精华帖 在 icon 上相同引起的误解
@codecov
Copy link

codecov bot commented May 6, 2018

Codecov Report

Merging #1032 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1032   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         131      131           
  Lines        5886     5886           
=======================================
  Hits         5796     5796           
  Misses         90       90
Impacted Files Coverage Δ
app/controllers/users/team_actions.rb 92.3% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f35f07f...bde8689. Read the comment docs.

<a href="<%= main_app.popular_topics_path %>" data-turbolinks-action="replace"> 优质帖子</a>
</li>
<li class="<%= ' active' if action_name == 'excellent' %>">
<a href="<%= main_app.excellent_topics_path %>" data-turbolinks-action="replace"><i class="fa fa-diamond"></i> 精华帖</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

精华放前面

@@ -34,7 +34,10 @@
<a href="<%= main_app.topics_path %>" data-turbolinks-action="replace">默认</a>
</li>
<li class="<%= ' active' if action_name == 'popular' %>">
<a href="<%= main_app.popular_topics_path %>" data-turbolinks-action="replace"><i class="fa fa-diamond"></i> 优质帖子</a>
<a href="<%= main_app.popular_topics_path %>" data-turbolinks-action="replace"> 优质帖子</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多了个空格

@huacnlee huacnlee merged commit 3a01f7e into ruby-china:master May 9, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants