Skip to content

Incompatible versions for version 1.3.x #1052

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
aandrieu opened this issue Jun 7, 2024 · 3 comments
Closed

Incompatible versions for version 1.3.x #1052

aandrieu opened this issue Jun 7, 2024 · 3 comments
Assignees

Comments

@aandrieu
Copy link

aandrieu commented Jun 7, 2024

Hello, I'm trying to test the last release (1.3.1) but it is not compatible with edge version.

I get the following bundle error:

Could not find compatible versions

Because concurrent-ruby-edge >= 0.7.0 depends on concurrent-ruby ~> 1.2.0
  and Gemfile depends on concurrent-ruby ~> 1.3.0,
  concurrent-ruby-edge >= 0.7.0 cannot be used.
So, because Gemfile depends on concurrent-ruby-edge ~> 0.7.0,
  version solving has failed.

I think the edge version should be bump to take into account the newly released version 1.3.

Thank you 🙏

@eregon
Copy link
Collaborator

eregon commented Jun 7, 2024

Also reported in #1050.

Though Bundler should be able to solve this automatically by staying on concurrent-ruby 1.2.x as a workaround, as long as you don't force a newer concurrent-ruby int your Gemfile (which seems the case here).

And indeed:

s.add_runtime_dependency 'concurrent-ruby', "~> #{Concurrent::VERSION}"

So probably we should relax that.

Part of the trouble is it's rather annoying to release concurrent-ruby-edge.
I'd rather merge the functionality in the main gem but have it namespaced under Concurrent::Edge, unfortunately it doesn't seem namespaced that way.

@eregon
Copy link
Collaborator

eregon commented Jun 7, 2024

I'll try to do a release of both soon to fix the immediate issue.

@eregon eregon self-assigned this Jun 7, 2024
eregon added a commit that referenced this issue Jun 7, 2024
…ruby

* i.e. >= MAJOR.MINOR & < (MAJOR+1)
* See #1052
@eregon
Copy link
Collaborator

eregon commented Jun 7, 2024

I released concurrent-ruby-edge 0.7.1, which depends on concurrent-ruby ~> 1.3 instead of 1.3.0, so that should solve it.

@eregon eregon closed this as completed Jun 7, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants