Skip to content

Fixing the case when description has not been initialized until markd… #365

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2016
Merged

Fixing the case when description has not been initialized until markd… #365

merged 1 commit into from
Apr 1, 2016

Conversation

texpert
Copy link
Contributor

@texpert texpert commented Apr 1, 2016

…own.

Catched it analyzing this error:

TypeError (wrong argument type nil (expected String)):

/home/thunder/.rvm/gems/ruby-2.3.0/bundler/gems/grape-swagger-18401c8ce1b1/lib/grape-swagger/markdown/redcarpet_adapter.rb:55:in `render'
/home/thunder/.rvm/gems/ruby-2.3.0/bundler/gems/grape-swagger-18401c8ce1b1/lib/grape-swagger/markdown/redcarpet_adapter.rb:55:in `markdown'
/home/thunder/.rvm/gems/ruby-2.3.0/bundler/gems/grape-swagger-18401c8ce1b1/lib/grape-swagger/endpoint.rb:121:in `description_object'

@dblock
Copy link
Member

dblock commented Apr 1, 2016

This needs a test and a CHANGELOG entry please.

@texpert
Copy link
Contributor Author

texpert commented Apr 1, 2016

Done.

@LeFnord
Copy link
Member

LeFnord commented Apr 1, 2016

👍 … thanks
… and please, squash commits

@texpert texpert force-pushed the fix_in_description_object branch from bf13e3e to 02d8b28 Compare April 1, 2016 23:12
@LeFnord
Copy link
Member

LeFnord commented Apr 1, 2016

cool 😄

@texpert
Copy link
Contributor Author

texpert commented Apr 1, 2016

:)

@LeFnord LeFnord merged commit 9a7e687 into ruby-grape:swagger-2.0 Apr 1, 2016
@texpert texpert deleted the fix_in_description_object branch April 1, 2016 23:35
LeFnord added a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
@LeFnord
Merge pull request ruby-grape#365 from texpert/fix_in_description_object
0810f0f 
Fixing the case when description has not been initialized until markd…
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
swagger-2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@texpert @dblock @LeFnord