replace request.env['HTTP_HOST'] with request.host_with_port #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add it to CHANGELOG and squash commits |
edvakf
force-pushed
the
x_forwarded_host
branch
from
4871168 to
96e8bfe
Compare
|
@LeFnord Thank you. I've pushed them. |
|
👍 |
|
It might actually be better to use |
|
Let me push it again. |
edvakf
force-pushed
the
x_forwarded_host
branch
from
96e8bfe to
3f02da5
Compare
edvakf
changed the title
|
please add a spec for last commit |
request.env['HTTP_HOST'] doesn't respect X-Forwarded-Host, whereas request.host does
edvakf
force-pushed
the
x_forwarded_host
branch
from
3f02da5 to
be53496
Compare
|
added |
|
👍 |
LeFnord
added a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
replace request.env['HTTP_HOST'] with request.host_with_port
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.env['HTTP_HOST'] doesn't respect X-Forwarded-Host, whereas request.host does