Skip to content

Fix for tags for path versioned endpoints #447

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

anakinj
Copy link
Contributor

@anakinj anakinj commented Jun 6, 2016

This should fix #446

@dblock
Copy link
Member

dblock commented Jun 6, 2016

Please check the build and update CHANGELOG.

@anakinj
Copy link
Contributor Author

anakinj commented Jun 6, 2016

Updated the Changelog.

The Build failing seemed to have been caused by some kind of connection issue on the runner. Seems to be working now.

@LeFnord
Copy link
Member

LeFnord commented Jun 6, 2016

👍 … thanks, for fixing

@LeFnord
Copy link
Member

LeFnord commented Jun 7, 2016

@anakinj … can you rebase it …

@anakinj anakinj force-pushed the fix-for-tags-for-path-versioned-endpoints branch from c8df6b7 to b3f0afa Compare June 8, 2016 04:35
@anakinj
Copy link
Contributor Author

anakinj commented Jun 8, 2016

@LeFnord, this is now rebased

@LeFnord
Copy link
Member

LeFnord commented Jun 8, 2016

👍 … thanks

@LeFnord LeFnord merged commit d3a010d into ruby-grape:master Jun 8, 2016
LeFnord pushed a commit to LeFnord/grape-swagger that referenced this pull request Feb 9, 2019
* Test for tags in a versioned endpoint

* Use the version from route when tagging endpoints

* Updated the CHANGELOG
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Path versioned endpoints gets the version as tag instead of namespace.
4 participants