Combine namespaces with their mount_path to allow APIs with specified mount_paths #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinLiddle
force-pushed
the
mount-path-fix
branch
from
3ed752b to
50aae3c
Compare
|
@KevinLiddle … thanks, this is really cool 👍 |
… mount_paths i.e. `mount SomeAPI => '/some_api'`
KevinLiddle
force-pushed
the
mount-path-fix
branch
from
50aae3c to
81db505
Compare
LeFnord
reviewed
Sep 21, 2016
| end | ||
|
|
||
| Class.new(Grape::API) do | ||
| mount namespaced_api => '/mounted' |
There was a problem hiding this comment.
can you use ruby 2+ Hash style?
There was a problem hiding this comment.
namespaced_api is a variable so I don't think I can
|
Thanks @LeFnord! Would you happen to have an idea of when this could get released? |
LeFnord
pushed a commit
to LeFnord/grape-swagger
that referenced
this pull request
Feb 9, 2019
… mount_paths (ruby-grape#505) i.e. `mount SomeAPI => '/some_api'`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept getting the following error when I tried to upgrade my grape and grape-swagger libraries:
which I traced back to how the namespaced routes are collected. The app I'm working on has a bunch of APIs, all mounted with a specified
mount_path:so this PR should fix the issue of generating proper swagger docs with APIs that have been mounted to a specific route. I think this makes sense, but let me know if I'm mistaken about something here.