-
Notifications
You must be signed in to change notification settings - Fork 476
Fix incorrect data type linking for request params of entity types #511
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix incorrect data type linking for request params of entity types #511
Conversation
14181e7
to
885a9ef
Compare
One question, why is the length set to 42? Is this somewhere in the json schema spec (or swagger spec)? |
great question, @JanStevens ! the answer is - no Idea :) this is a part of current code (https://github.com/ruby-grape/grape-swagger/pull/511/files#diff-7af39528837333c960830618fb6a52e9L297) which is not documented |
Yes I know, The reason why I'm asking is that our current project has different namespaces and internal and public apis. So our entities end up being My current fix is to define a |
Can someone from maintainers bring some light here? |
Yeap, I did it, cause 42 is the answer of all 😉 … will create a PR tonight, which remove the limit, ok? |
Maybe also document the |
b160428
to
75a79ae
Compare
75a79ae
to
5c76186
Compare
thanks @serggl … good job 😄 |
This is a fix for #507.
Few moments were changed:
models
option inadd_swagger_documentation
method from now on, since it looks mostly like a workaround"type": "TypeA"
to"$ref": "#/definitions/TypeA"