-
Notifications
You must be signed in to change notification settings - Fork 476
Allow extension keys in Info Object #588
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @mattyr … but
- make rubocop happy → run
bundle exec rake
to see the failures - missing changelog entry
- please add a entry to extension section in the README
- make rubocop happy - add changelog entry - add entry to extension section in the README
made the requested changes -- also made the extension format conform better with existing extensions ( quick question re: rubocop: i was getting a ton of errors so i thought that was ignored. looks like 99% are "Missing frozen string literal comment". I disabled that using .rubocop.yml file and just addressed those issues specific to these changes. Would you like a PR that either:
|
@mattyr … its a bit curious that this cop pops up, cause it is running some weeks, but prefer not to mix up your PR with a maintainance PR, and yeah here is it green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 very cool, thanks
* Allow extension keys in Info Object, per http://swagger.io/specification/#infoObject * address comments - make rubocop happy - add changelog entry - add entry to extension section in the README * fix changelog entry * another changelog fix
per http://swagger.io/specification/#infoObject