Handle cases where a route's prefix is a nested URL #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mmh for me the changes are reasonable, but please adept the specs and/or add one which documents the behaviour |
SimonKaluza
force-pushed
the
handle-route-prefixes
branch
3 times, most recently
from
6167858 to
f70bcbc
Compare
Nested prefixes (any prefix containing a '/' character) prior to this commit would incorrectly get tagged as the first segment of the URL prefix. E.g. a route like "api/beta/v1/patients" would incorrectly get tagged as "api" instead of "patients" Added a nested prefix to the namespace_tags prefix RSpec -- this example breaks without the changes to endpoint.rb.
SimonKaluza
force-pushed
the
handle-route-prefixes
branch
from
f70bcbc to
db1ad06
Compare
|
Added a RSpec example with tags that breaks without the adjustments made to endpoint.rb to support nested prefix and rebased off of the current master (hence the force-pushes) |
|
thanks @SimonKaluza |
aka-momo
pushed a commit
to aka-momo/grape-swagger
that referenced
this pull request
Feb 8, 2023
Nested prefixes (any prefix containing a '/' character) prior to this commit would incorrectly get tagged as the first segment of the URL prefix. E.g. a route like "api/beta/v1/patients" would incorrectly get tagged as "api" instead of "patients" Added a nested prefix to the namespace_tags prefix RSpec -- this example breaks without the changes to endpoint.rb.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested prefixes (any prefix containing a '/' character) prior to this commit would incorrectly get tagged as the first segment of the URL prefix.
E.g. a route like "api/beta/v1/patients" would incorrectly get tagged as "api" instead of "patients"