Skip to content

Add Extensions for Params #785

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Apr 17, 2020
Merged

Add Extensions for Params #785

merged 3 commits into from
Apr 17, 2020

Conversation

MaximeRVY
Copy link
Contributor

Hello,

I've made a PR for this issue : #784

close 784

@coveralls
Copy link

coveralls commented Apr 6, 2020

Coverage Status

Coverage increased (+0.002%) to 99.454% when pulling 2e09d27 on MaximeRDY:master into 498246e on ruby-grape:master.

@dblock
Copy link
Member

dblock commented Apr 15, 2020

Thank you. We document extensions in README, how does this relate to that? Feels like this needs a documentation update.

@MaximeRVY
Copy link
Contributor Author

Hello @dblock,
You are right :-)
I've added the documentation.
Feel free if you have any remarks

@dblock
Copy link
Member

dblock commented Apr 16, 2020

LGTM, leaving to @LeFnord or another active maintainer

@LeFnord
Copy link
Member

LeFnord commented Apr 16, 2020

thanks @MaximeRDY … only one last thing

@LeFnord
Copy link
Member

LeFnord commented Apr 17, 2020

thanks again @MaximeRDY

@LeFnord LeFnord merged commit 077a274 into ruby-grape:master Apr 17, 2020
aka-momo pushed a commit to aka-momo/grape-swagger that referenced this pull request Feb 8, 2023
* Add Extensions for Params

* Add Documentation for `x:` in params

* Remove require `pry`
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants