Parameter examples #821
Merged
Parameter examples #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, once I put this PR into action I find that the examples still aren't present in the resulting swagger file. Is there something I'm missing? |
|
thanks @dslh … to your question, I have no idea, your code and your spec are looking good, so maybe you want to investigate a bit more? |
|
@dslh … what did you think, should it be mörged and you investigate your issue in a separate PR … mayve it is not related to grape-swagger more to the used swagger client? |
LeFnord
reviewed
Mar 16, 2021
| optional :obj, type: 'Object', documentation: { example: { 'foo' => 'bar' } } | ||
| end | ||
|
|
||
| get '/endpoint_with_examples' do |
There was a problem hiding this comment.
@dslh … try with a post request ;)
Merged
aka-momo
pushed a commit
to aka-momo/grape-swagger
that referenced
this pull request
Feb 8, 2023
Co-authored-by: peter scholz <pscholz.le@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. It would be useful for us to be able to specify example values for parameters, as per the spec. I'm not familiar with the internals of this project, let me know if I'm missing something in the implementation or tests. Thanks!
Closes #762.