Skip to content

Fix example to work without error #852

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Conversation

takahashim
Copy link
Contributor

Fix #851.

  • load grape-swagger-entity gem in :development environment
  • require gem files with Bundler.require

I have a few concerns about this fix.

  • We can remove other requires in config.ru such as require 'rack/cors'. Should I remove them?
  • Instead of adding the grape-swagger-entity gem in :development to the common Gemfile, should I add another Gemfile for example as example/Gemfile ?

@LeFnord
Copy link
Member

LeFnord commented Mar 11, 2022

Hi @takahashim … thanks for it, to your concerns:

  1. it would be nice
  2. think it is not needed, cause it is for development, the gem itself doesn't require it

@takahashim
Copy link
Contributor Author

Thank you! Fixed it and resolved the conflict.

@LeFnord
Copy link
Member

LeFnord commented Mar 13, 2022

thanks @takahashim

@LeFnord LeFnord merged commit 5e0af24 into ruby-grape:master Mar 13, 2022
aka-momo pushed a commit to aka-momo/grape-swagger that referenced this pull request Feb 8, 2023
Bhacaz pushed a commit to Bhacaz/grape-swagger that referenced this pull request Aug 31, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GrapeSwagger::Errors::UnregisteredParser in example
2 participants