-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fixes issue by checking if there's a base is there at all #1946
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# frozen_string_literal: true | ||
|
||
require 'spec_helper' | ||
require 'shared/versioning_examples' | ||
|
||
describe Grape::API::Instance do | ||
subject(:an_instance) do | ||
Class.new(Grape::API::Instance) do | ||
namespace :some_namespace do | ||
get 'some_endpoint' do | ||
'success' | ||
end | ||
end | ||
end | ||
end | ||
|
||
let(:root_api) do | ||
to_mount = an_instance | ||
Class.new(Grape::API) do | ||
mount to_mount | ||
end | ||
end | ||
|
||
def app | ||
root_api | ||
end | ||
|
||
context 'when an instance is mounted on the root' do | ||
it 'can call the instance endpoint' do | ||
get '/some_namespace/some_endpoint' | ||
expect(last_response.body).to eq 'success' | ||
end | ||
end | ||
|
||
context 'when an instance is the root' do | ||
let(:root_api) do | ||
to_mount = an_instance | ||
Class.new(Grape::API::Instance) do | ||
mount to_mount | ||
end | ||
end | ||
|
||
it 'can call the instance endpoint' do | ||
get '/some_namespace/some_endpoint' | ||
expect(last_response.body).to eq 'success' | ||
end | ||
end | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be doing this check inside
base_instance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense, as
base_instance?
usually means: "This instance is not used anywhere and is just a template for other instances" while, if an API has nobase
, it will most likely be used directly