-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support for rdf and linkeddata ~>3.0 #10
Comments
Hi, Of course we can also merge into master and shift ownership to someone who would actually maintain it (interested?) |
We can definitely host it on ruby-rdf, but you'll need to transfer it, as there it shows up as a fork. It will require the ability to release through RubyGems as well. It doesn't look to me that it's been touched in a long time, and someone willing to take this on would be most welcome. |
@gkellogg : I'm ready to transfer ownership to ruby-rdf, though I think you need to remove the fork first. Will transfer as soon as the fork is gone. |
Okay, deleted. If you could add gregg@greggjellogg.net to RubyGems, I can take care of releasing updates, too. |
Ok, added you as gem owner.
Seems I need create rights on ruby-rdf to transfer ownership though
ons. 27. mar. 2019 kl. 19:03 skrev Gregg Kellogg <notifications@github.com>:
… Okay, deleted. If you could add ***@***.*** to RubyGems, I can
take care of releasing updates, too.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWLSj1Pb0cvwL4e3QezgdT3iS-rl4Piks5va7J7gaJpZM4cOFXH>
.
|
This sounds great! An issue I've only just noticed, which may or not affect moving to ruby-rdf - this gem is licensed as GPL-3, whereas ruby-rdf packages I've looked at seem to be Unlicense. I only just noticed this, and GPL-3 does seem to prevent me using it in our app (which is BSD-3) :( |
@bensinober I changed your role to "owner" so you can do this. I can later re-attach the "Virtuoso" team to the repository and put role back to "member". |
@stuzart It would be great to have you as a maintainer, as I don't use the gem myself. Once the repo is transferred over, I can add you as a team member. I agree that it would be best if the licenses were aligned, which will require buy-in from the contributors. In addition to @bensinober, this includes @pkordel and @boutros. |
Done!
Benjamin
ons. 27. mar. 2019 kl. 21:14 skrev Gregg Kellogg <notifications@github.com>:
… @bensinober <https://github.com/bensinober> I changed your role to
"owner" so you can do this. I can later re-attach the "Virtuoso" team to
the repository and put role back to "member".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWLSlNZAJXMco4neXcCNdrcUN-1adE9ks5va9E_gaJpZM4cOFXH>
.
|
We should also have a Travis build environment, perhaps using a Virtuoso docker image. Look to one of the other gems such as rdf-mongo for a standard setup for running services. Travis has instructions for using docker. |
Default branch is now "develop", which is the case for the other repos as well. |
@gkellogg yes, please go ahead and add me as a team member :) I can also sort out the Travis build. Running with the Virtuoso docker image also solves a problem of my own, as I currently run my integration tests against the docker image manually rather than with travis, something I keep meaning to fix and wasn't aware Travis had this ability, so thanks for the link. |
Hi, did you make any progress? |
Comparing with the rdf-mongo repo, the repository_spec should probably include something like following, to hammer out corner cases. before :each do
@repository.collection.drop
end
after :each do
@repository.collection.drop
end
# @see lib/rdf/spec/repository.rb in RDF-spec
it_behaves_like "an RDF::Repository" do
let(:repository) {@repository}
end |
Help wanted on this issue. It would be great to update the GitHub Actions CI task to bring up Virtuoso and run against the shared Repository specs. |
Actually, a new issue for improving tests is appropriate. The gem now depends on |
I used the rdf-virtuoso gem as part of a Rails app, together with linkedata and rdf gems.
As part of a Rails upgrade, I've found I need to update to a newer rdf gem, ideally the latest version which is 3.0.10. I've been wanting to update for some time anyway, but was held back by the rdf-virtuoso dependencies.
I started updating the gem to create a pull request, but then found the required changes had already been contributed to the 'develop' branch.
I'm now using that branch directly from github in my Gemfile. The current rspec tests for the branch pass, and my own integration tests in my own Rails app all pass fine.
So
The text was updated successfully, but these errors were encountered: