Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support for rdf and linkeddata ~>3.0 #10

Closed
stuzart opened this issue Mar 27, 2019 · 16 comments
Closed

Support for rdf and linkeddata ~>3.0 #10

stuzart opened this issue Mar 27, 2019 · 16 comments
Labels
help wanted Great place for a new contribution

Comments

@stuzart
Copy link
Member

stuzart commented Mar 27, 2019

I used the rdf-virtuoso gem as part of a Rails app, together with linkedata and rdf gems.
As part of a Rails upgrade, I've found I need to update to a newer rdf gem, ideally the latest version which is 3.0.10. I've been wanting to update for some time anyway, but was held back by the rdf-virtuoso dependencies.

I started updating the gem to create a pull request, but then found the required changes had already been contributed to the 'develop' branch.

I'm now using that branch directly from github in my Gemfile. The current rspec tests for the branch pass, and my own integration tests in my own Rails app all pass fine.

So

  1. Is it safe to use the current version sitting on the develop branch?
  2. I'm curious why this hasn't been released and pushed as a gem. The current version is quite old and I'm sure there are others that would benefit.
@bensinober
Copy link
Contributor

Hi,
quite a long time since we had something to do with this, but I suppose you would be all right using the develop branch for now. We thought it would be moved to https://github.com/ruby-rdf/rdf-virtuoso but I'm not sure why that stopped short.

Of course we can also merge into master and shift ownership to someone who would actually maintain it (interested?)
Regards
Benjamin

@gkellogg
Copy link
Member

We can definitely host it on ruby-rdf, but you'll need to transfer it, as there it shows up as a fork. It will require the ability to release through RubyGems as well.

It doesn't look to me that it's been touched in a long time, and someone willing to take this on would be most welcome.

@bensinober
Copy link
Contributor

@gkellogg : I'm ready to transfer ownership to ruby-rdf, though I think you need to remove the fork first. Will transfer as soon as the fork is gone.
Benjamin

@gkellogg
Copy link
Member

Okay, deleted. If you could add gregg@greggjellogg.net to RubyGems, I can take care of releasing updates, too.

@bensinober
Copy link
Contributor

bensinober commented Mar 27, 2019 via email

@stuzart
Copy link
Member Author

stuzart commented Mar 27, 2019

This sounds great!
If you need help maintaining, I can help at least with keeping the dependencies up to date with ruby-rdf

An issue I've only just noticed, which may or not affect moving to ruby-rdf - this gem is licensed as GPL-3, whereas ruby-rdf packages I've looked at seem to be Unlicense. I only just noticed this, and GPL-3 does seem to prevent me using it in our app (which is BSD-3) :(

@gkellogg
Copy link
Member

@bensinober I changed your role to "owner" so you can do this. I can later re-attach the "Virtuoso" team to the repository and put role back to "member".

@gkellogg
Copy link
Member

@stuzart It would be great to have you as a maintainer, as I don't use the gem myself. Once the repo is transferred over, I can add you as a team member.

I agree that it would be best if the licenses were aligned, which will require buy-in from the contributors. In addition to @bensinober, this includes @pkordel and @boutros.

@bensinober
Copy link
Contributor

bensinober commented Mar 27, 2019 via email

@gkellogg
Copy link
Member

We should also have a Travis build environment, perhaps using a Virtuoso docker image. Look to one of the other gems such as rdf-mongo for a standard setup for running services. Travis has instructions for using docker.

@gkellogg
Copy link
Member

gkellogg commented Mar 27, 2019

Default branch is now "develop", which is the case for the other repos as well.

@stuzart
Copy link
Member Author

stuzart commented Mar 28, 2019

@gkellogg yes, please go ahead and add me as a team member :)

I can also sort out the Travis build. Running with the Virtuoso docker image also solves a problem of my own, as I currently run my integration tests against the docker image manually rather than with travis, something I keep meaning to fix and wasn't aware Travis had this ability, so thanks for the link.

@mehmetc
Copy link

mehmetc commented Jun 14, 2020

Hi, did you make any progress?
In my enthusiasm I forked and bumped the dependencies to the latest version. The tests work but there might still be a catch that needs to surface.

@gkellogg
Copy link
Member

Comparing with the rdf-mongo repo, the repository_spec should probably include something like following, to hammer out corner cases.

  before :each do
    @repository.collection.drop
  end
 
  after :each do
    @repository.collection.drop
  end


  # @see lib/rdf/spec/repository.rb in RDF-spec
  it_behaves_like "an RDF::Repository" do
    let(:repository) {@repository}
  end

@gkellogg
Copy link
Member

gkellogg commented Apr 8, 2021

Help wanted on this issue. It would be great to update the GitHub Actions CI task to bring up Virtuoso and run against the shared Repository specs.

@gkellogg gkellogg added the help wanted Great place for a new contribution label Apr 8, 2021
@gkellogg
Copy link
Member

gkellogg commented Apr 8, 2021

Actually, a new issue for improving tests is appropriate. The gem now depends on rdf ~> 3.1.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
help wanted Great place for a new contribution
Projects
None yet
Development

No branches or pull requests

4 participants