GitHub testing with virtuoso service #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include the tenforce/virutoso docker container as a service in the github ci.yml however, currently just the service, not yet included in any tests #15
a simple check that the repo is connecting and querying within the Github CI environment
after the container starts, it needs just a couple of seconds to initialise. Hopefully 3s is enough to avoid any sporadic errors #15
the previous one gave a warning
check with a single select which is unlikely to change, and also include a simple insert #15
explicity setting the let(:repository) caused an infinite loop and stack overflow, because the subject is already named it works without #15
|
|
gkellogg
reviewed
Apr 14, 2021
Co-authored-by: Gregg Kellogg <gregg@greggkellogg.net>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll submit this now as a PR towards addressing issue #15
It includes an extension to the Github CI workflow to include the virtuoso docker service. There is then also a new spec (named integration_spec.rb, but maybe this should go in repository_spec.rb with its own concern, I'm not clear on rspec conventions with these types of integration tests) which is configured to setup an
RDF::Virtuoso::Repositoryto connect to the docker service.There are a couple of sanity tests to check that a select and insert can be successfully made against the docker service.
I've also added a call to
it_behaves_like "an RDF::Repository"for the conformance tests - however this is currently commented out as it raised many errors. It may take some time to fix all of these, but since many seem to have a similar error it is possible they all have a common cause.The tests are skipped unless the env variable
VIRTUOSO_INTEGRATION_TESTSexists, which is set in the CI workflow, and there are instructions on how to run locally within the spec file.