Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove referenced components list #136

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

stephannv
Copy link
Contributor

Display only components related to current component page, removing "Referenced components" list.

Before:
Screenshot 2024-11-11 at 17 38 21

After:
Screenshot 2024-11-11 at 17 38 27

@stephannv stephannv requested a review from cirdes November 11, 2024 20:41
@@ -2,7 +2,7 @@

class Docs::CheckboxGroupView < ApplicationView
def view_template
component = "Checkbox Group"
component = "Checkbox"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary because component_files helper uses component name to find component folder, and CheckboxGroup is inside checkbox folder.

@sethhorsley
Copy link
Collaborator

I think this is a good pr. Makes things simpler!

Copy link
Collaborator

@sethhorsley sethhorsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@stephannv stephannv merged commit aec0f12 into ruby-ui:main Nov 12, 2024
5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants