Optimizations and cleanup for the JRuby extension #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves performance by having fewer dynamic writes.
This eliminates the context field on ParserSession, ByteListTranscoder, and Generator.Session as well as accesses of the runtime through it. These runtime structures should generally be passed on the stack rather than being stored into long-lived objects, even if they may be GCed quickly.
It's more efficient to compare the Encoding object and for the rare cases where we need to transcode to UTF-8 just look it up again.
Rarely used, mostly at boot, and probably just as quick to look up the constant as go through the weak reference.
Previous logic would only pass the string through if its encoding was exactly UTF-8. New logic passes through UTF-8 and US-ASCII and handles other encodings like CRuby.
Using an output stream here is just added overhead compared to writing directly to a ByteList. Instead, we move the OutputStream logic into StringEncoder and restore direct ByteList writing to StringDecoder.
|
This is done and ready for review. @byroot let me know if you have any concerns. |
|
I don't have much Java expertise, so feel free to merge if you're ready. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.