Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dump Date/DateTime as proleptic Gregorian date as well as Time #573

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

nobu
Copy link
Member

@nobu nobu commented Aug 9, 2022

Fix #572

@nobu
Copy link
Member Author

nobu commented Aug 9, 2022

The YAML spec does not seem to mention about calendar systems at all.

@nobu nobu requested a review from tenderlove August 9, 2022 09:58
@nobu
Copy link
Member Author

nobu commented Aug 9, 2022

Asked yaml/yaml#69.

@v2kovac
Copy link

v2kovac commented Jun 7, 2023

I'm pretty sure this broke my deserialization of Date.

a  = Date.today.to_yaml # "--- 2023-06-07\n"
YAML.unsafe_load(a) # return "2023-06-07" instead of Date object

very confusing since this is a minor version change, i don't see other people complaining about this though

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Calendar info in Date/DateTime is lost
3 participants