Fixed bug: Reenabled task raises previous exception on second invokation #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…beeing reenable-d.
yuki24
reviewed
Aug 22, 2018
lib/rake/task.rb
Outdated
| @@ -141,7 +141,8 @@ def arg_names | |||
| # Reenable the task, allowing its tasks to be executed if the task | |||
| # is invoked again. | |||
| def reenable | |||
| @already_invoked = false | |||
| @already_invoked = false | |||
There was a problem hiding this comment.
I’m not super opinionated about this change, but this would slightly mess up git blame and sometimes it may be more annoying than just looking nice.
… looking indentaiton.
|
Thanks for merging @hsbt ❤️ |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a task is
reenabled an exception of the pre-reenableinvocation should not be raised but is.