Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add logger library types #316

Merged
merged 7 commits into from
Jul 12, 2020
Merged

Add logger library types #316

merged 7 commits into from
Jul 12, 2020

Conversation

pocke
Copy link
Member

@pocke pocke commented Jun 28, 2020 •
edited
Loading

This pull request adds logger library types.

@pocke pocke force-pushed the logger branch 2 times, most recently from 3919bfb to cbc9462 Compare June 28, 2020 06:12
@ghost
Copy link

ghost commented Jul 4, 2020 •
edited by ghost
Loading

Errors or warnings were resolved via the commit e63bb79!✅

Visit the analysis result for details.

pocke
pocke commented Jul 11, 2020
View reviewed changes
stdlib/logger/log_device.rbs
class Logger
class LogDevice
# TODO: Write type signature for MonitorMixin
# include MonitorMixin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RBS doesn't have MonitorMIxin type, so I commented out it with a TODO comment.

@pocke pocke changed the title WIP Add logger library types Add logger library types Jul 11, 2020
@pocke pocke marked this pull request as ready for review July 11, 2020 11:10
soutaro
soutaro approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🦞

@soutaro soutaro merged commit fe323c6 into ruby:master Jul 12, 2020
@pocke pocke deleted the logger branch July 12, 2020 06:33
pocke added a commit to pocke/rbs that referenced this pull request Dec 15, 2020
@pocke
Add include MonitorMixin to Logger::LogDevice
b984cc7 
Logger type has been added in ruby#316, but MonitorMixin type didn't exist at that time.
Recently I added MonitorMixin type by ruby#485, so we can add the `include`
clause to Logger::LogDevice.
@pocke pocke mentioned this pull request Dec 15, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pocke @soutaro