-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add signatures of cgi/core #599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @masahito1997!
I put some requests in the pull request. 🙏
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
fix indent remove useless code
@soutaro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masahito1997 Looks great, thank you!
Fixup the commits if you want.
This PR adds signatures of cgi/core
references: