Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add signatures of cgi/core #599

Merged
merged 7 commits into from
Mar 7, 2021
Merged

Conversation

m11o
Copy link
Contributor

@m11o m11o commented Feb 13, 2021

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @masahito1997!

I put some requests in the pull request. 🙏

m11o and others added 6 commits February 17, 2021 22:59
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
Co-authored-by: Soutaro Matsumoto <matsumoto@soutaro.com>
fix indent

remove useless code
@m11o
Copy link
Contributor Author

m11o commented Feb 17, 2021

@soutaro
Thank you for your suggestions and modifications 🙏
In addition, I fixed test and added small modifications
Please review it again.

@m11o m11o requested a review from soutaro February 17, 2021 15:01
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masahito1997 Looks great, thank you!

Fixup the commits if you want.

@soutaro soutaro merged commit 89471c8 into ruby:master Mar 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants