Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix Hash#compact signature #637

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Fix Hash#compact signature #637

merged 1 commit into from
Mar 15, 2021

Conversation

kachick
Copy link
Member

@kachick kachick commented Mar 13, 2021 

ruby -v -e 'p Class.new(Hash)[:a, nil].compact.class'

outputs

ruby 3.0.0p0 (2020-12-25 revision 95aff21468) [x86_64-darwin20]
Hash

soutaro
soutaro approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#️⃣

@soutaro soutaro merged commit 9df5046 into ruby:master Mar 15, 2021
@kachick
Copy link
Member Author

kachick commented Mar 15, 2021

Thank you!

@kachick kachick deleted the hash-subsclass-compact-returns-hash branch March 15, 2021 08:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@soutaro soutaro soutaro approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kachick @soutaro