a is a String that always match to these regexp because ExplicitLink:a is created by "{#{l}}[#{s}]".
#1322
Assignees
Comments
|
@tompng as per our discussion, I've pulled this out into a follow-up action. Let me know if there is anything I can do here to help. It sounds like you have a strong opinion about how to refactor this, so I'm happy to defer to you. |
tompng
added a commit
that referenced
this issue
Mar 23, 2025
Create intermediate rule ExplicitLinkWithLabel that returns `{label:,
link:}`, so that Image rule does not need to re-parse rdoc link format
again.
```ruby
# Before
"[text](url)" → "{text}(url)"
"" → Image("{text}(url)") →(parse with regexp)→ "rdoc-image:url:text"
# After
"[text](url)" → ExplicitLink({ label: 'text', link: 'url' }) → "{text}(url)"
"" → Image({ label: 'text', link: 'url' }) → "rdoc-image:url:text"
```
#1322
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Perhaps it could be more simple if
ExplicitLinkreturns structured dataExplicitLink = Label:l "(" @Sp Source:s Spnl Title @Sp ")" - { "{#{l}}[#{s}]" } # returns string, need to parse this string again... + { { label: l, source: s } } # can return hash(need to change
Link = ExplicitLink | ReferenceLink | AutoLinkto return a string if ExplicitLink returns hash)Originally posted by @tompng in #1320 (comment)
The text was updated successfully, but these errors were encountered: