Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Clarify variable name #218

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Clarify variable name #218

merged 2 commits into from
Oct 30, 2024

Conversation

kevinebaugh
Copy link
Contributor

@naitoh what do you think?

olleolleolle
olleolleolle reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about making the name a plural?

@naitoh
Copy link
Contributor

naitoh commented Oct 29, 2024

How about making the name a plural?

Me, too.
@encoded_terms looks good.

@kevinebaugh @olleolleolle
Pluralize
29b2bec 
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
@kevinebaugh
Copy link
Contributor Author

How about making the name a plural?

Me, too. @encoded_terms looks good.

👍 29b2bec

@kevinebaugh kevinebaugh changed the title encord → encode Clarify variable name Oct 29, 2024
@kou kou merged commit 519ae6c into ruby:master Oct 30, 2024
61 checks passed
@kou
Copy link
Member

kou commented Oct 30, 2024

Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@olleolleolle olleolleolle olleolleolle left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinebaugh @naitoh @kou @olleolleolle