Improve comment parse performance #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
reviewed
Mar 3, 2025
naitoh
force-pushed
the
improve_comment_parse_performance
branch
3 times, most recently
from
f89826b to
62c44a9
Compare
kou
reviewed
Mar 3, 2025
## Benchmark (Comparison with rexml 3.4.1)
```
$ benchmark-driver benchmark/parse_comment.yaml
Calculating -------------------------------------
rexml 3.4.1 master 3.4.1(YJIT) master(YJIT)
top_level 999.440 5.058k 922.416 3.340k i/s - 100.000 times in 0.100056s 0.019770s 0.108411s 0.029936s
in_doctype 1.063k 4.890k 980.498 3.341k i/s - 100.000 times in 0.094116s 0.020449s 0.101989s 0.029927s
after_doctype 638.321 1.304k 603.952 1.153k i/s - 100.000 times in 0.156661s 0.076710s 0.165576s 0.086748s
Comparison:
top_level
master: 5058.2 i/s
master(YJIT): 3340.5 i/s - 1.51x slower
rexml 3.4.1: 999.4 i/s - 5.06x slower
3.4.1(YJIT): 922.4 i/s - 5.48x slower
in_doctype
master: 4890.2 i/s
master(YJIT): 3341.5 i/s - 1.46x slower
rexml 3.4.1: 1062.5 i/s - 4.60x slower
3.4.1(YJIT): 980.5 i/s - 4.99x slower
after_doctype
master: 1303.6 i/s
master(YJIT): 1152.8 i/s - 1.13x slower
rexml 3.4.1: 638.3 i/s - 2.04x slower
3.4.1(YJIT): 604.0 i/s - 2.16x slower
```
- YJIT=ON : 1.90x - 3.62x faster
- YJIT=OFF : 2.04x - 5.06x faster
naitoh
force-pushed
the
improve_comment_parse_performance
branch
from
62c44a9 to
b16d62e
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark (Comparison with rexml 3.4.1)