Cleanup based on review

ruby · Mar 11, 2025 · 29d6dd3 · 29d6dd3
1 parent 2502fcd
commit 29d6dd3
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/common.js b/common.js
@@ -410,23 +410,28 @@ export async function setupJavaHome() {
   core.startGroup(`Modifying JAVA_HOME for JRuby`)
 
   console.log("attempting to run with existing JAVA_HOME")
+
   let ret = await exec.exec('ruby', ['--version']);
 
   if (ret === 0) {
     console.log("JRuby successfully starts, using existing JAVA_HOME")
   } else {
     console.log("JRuby failed to start, try Java 21 envs")
+
     let arch = os.arch();
-    if (arch == "x64" || os.platform() != "darwin") {
+    if (arch === "x64" || os.platform() !== "darwin") {
       arch = "X64"
     }
+
     let newHomeVar = `JAVA_HOME_21_${arch}`;
     let newHome = process.env[newHomeVar];
 
     if (newHome === "undefined") {
       throw new Error(`JAVA_HOME is not Java 21+ needed for JRuby and \$${newHomeVar} is not defined`)
     }
+
     console.log(`Setting JAVA_HOME to ${newHomeVar} path ${newHome}`)
+
     core.exportVariable("JAVA_HOME", newHome)
   }
 

diff --git a/dist/index.js b/dist/index.js
diff --git a/index.js b/index.js
@@ -79,7 +79,7 @@ export async function setupRuby(options = {}) {
 
   const rubyPrefix = await installer.install(platform, engine, version)
 
-  if (engine == "jruby") {
+  if (engine === "jruby") {
     await common.setupJavaHome();
   }