Body should be non-frozen by default. (#103)

ruby · Jan 27, 2023 · af5d2f5 · af5d2f5
1 parent 9501735
commit af5d2f5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/webrick/httpresponse.rb b/lib/webrick/httpresponse.rb
@@ -122,7 +122,7 @@ def initialize(config)
       @status = HTTPStatus::RC_OK
       @reason_phrase = nil
       @http_version = HTTPVersion::convert(@config[:HTTPVersion])
-      @body = ''
+      @body = +""
       @keep_alive = true
       @cookies = []
       @request_method = nil
@@ -441,7 +441,7 @@ def check_header(header_value)
     # :stopdoc:
 
     def error_body(backtrace, ex, host, port)
-      @body = +''
+      @body = +""
       @body << <<-_end_of_html_
 <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0//EN">
 <HTML>

diff --git a/test/webrick/test_httpresponse.rb b/test/webrick/test_httpresponse.rb
@@ -28,6 +28,10 @@ def setup
       @res.keep_alive  = true
     end
 
+    def test_response_body_not_frozen
+      refute @res.body.frozen?
+    end
+
     def test_prevent_response_splitting_headers_crlf
       res['X-header'] = "malicious\r\nCookie: cracked_indicator_for_test"
       io = StringIO.new