Skip to content

Fix ISO 8601 timestamp formatting #72

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

getsnoopy
Copy link

No description provided.

@@ -529,7 +529,7 @@ def set_dir_list(req, res)
dname = name
end
s = +"<TR><TD class=\"name\"><A HREF=\"#{HTTPUtils::escape(name)}#{query if name.end_with?('/')}\">#{HTMLUtils::escape(dname)}</A></TD>"
s << "<TD class=\"mtime\">" << (time ? time.strftime("%Y/%m/%d %H:%M") : "") << "</TD>"
s << "<TD class=\"mtime\">" << (time ? time.strftime("%Y-%m-%d %H:%M") : "") << "</TD>"
Copy link
Member

@gotoken gotoken Sep 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are two difficulties

  1. Maybe there already exist log analyzers uses the current format even if %Y-%m-%d is better to read for people in some locales.
  2. ISO 8601 needs putting T between %Y-%m-%d and %H:%M, i.e., %Y-%m-%dT%H:%M. And it's not clear which is better, "%Y/%m/%d %H:%M or %Y-%m-%dT%H:%M.

@ioquatix
Copy link
Member

By my check, this is not ISO 8601 formatting. Do you mind explaining the problem you are trying to solve? Or is it purely cosmetic?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants