Config doesn't have to be a Rails Engine #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkuczynski
requested review from
rdubya,
pkuczynski,
pyromaniac and
supremebeing7
|
@amatsuda thank you for your contribution. Could you please add CHANGELOG entry? @pyromaniac @rdubya @supremebeing7 what you think about this PR? |
Done! |
pkuczynski
approved these changes
Jan 3, 2020
|
Thanks! Sorry for such a long time for merging this one... |
|
Will be released soon with 2.2.0 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that Config defines an isolated Engine class under Rails environment, but this simple plugin actually does not use Rails Engine feature at all. This plugin already has a Railtie, and that's enough for doing things that this plugin offers.
Creating an unused Engine class like this is not just unnecessary but indeed rather harmful for the users' applications, because it slows down the application initialization process, consumes much memory, and slows down auto/eager loading, request handling, rendering, etc. by adding entries for them.