-
-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Upgrade development dependencies and test matrix with latest Ruby and Rails versions #264
Conversation
config.gemspec
Outdated
@@ -28,7 +28,7 @@ Please consider donating to our open collective to help us maintain this project | |||
s.required_ruby_version = '>= 2.4.0' | |||
|
|||
s.add_dependency 'deep_merge', '~> 1.2', '>= 1.2.1' | |||
s.add_dependency 'dry-validation', '~> 1.0' | |||
s.add_dependency 'dry-validation', '~> 1.4.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you pinning so tightly here? A comment would be helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think s.add_dependency 'dry-validation', '~> 1.4'
would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, much better. Thanks
No description provided.