Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add error catching for whatever untested terrible thing may be happen… #5656

Merged
merged 1 commit into from
May 5, 2024

Conversation

compwron
Copy link
Collaborator

@compwron compwron commented May 5, 2024

…ing with the new design and preventing case contact creation in prod

What github issue is this PR for, if any?

Resolves #XXXX

What changed, and why?

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions:

How is this tested? (please write tests!) 💖💪

Screenshots please :)

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

…ing with the new design and preventing case contact creation in prod
@compwron compwron merged commit ec92bdf into main May 5, 2024
8 of 11 checks passed
@compwron compwron deleted the fix-prod-more-2 branch May 5, 2024 04:10
@github-actions github-actions bot added the ruby Pull requests that update Ruby code label May 5, 2024
if params.dig(:case_contact, :case_contact_contact_type_attributes)
@case_contact.case_contact_contact_type.destroy_all
begin
if params.dig(:case_contact, :case_contact_contact_type_attributes) # TODO this sometimes raises errors in prod.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was referenced May 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant