Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve report generation modal #5931

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve report generation modal #5931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/views/case_court_reports/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@
}

const setTimeZone = () => {
if(!$('#case-selection').val()){
alert('Select an active case and specify the date range.');
}
Comment on lines +50 to +52
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

honestly i don't love how the default alert looks, I would like it to highlight the field that has the error.

I would be fine with this if I can be done as an HTML attribute otherwise lets just ditch the client side JS requirement.

const timeZone = Intl.DateTimeFormat().resolvedOptions().timeZone
document.getElementById("user-time-zone").value = timeZone
}
Expand Down
6 changes: 6 additions & 0 deletions public/assets/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,6 +1085,12 @@ h6,
color: #262d3f;
display: block;
margin-bottom: 10px; }
.input-style-1 select{
width: 465px;
height: 40px;
border-radius: 5px;
border: 1px solid #4a6cf7;
}
Comment on lines +1088 to +1093
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit isn't actually showing up for me

image

I think it is because you are styling the select whereas you need to style the span that the select2 dropdown generates. Also it would be better if you could do the styles with bootstrap CSS classes. https://getbootstrap.com/docs/5.3/utilities/borders/#radius stuff line that.

.input-style-1 input,
.input-style-1 textarea {
width: 100%;
Expand Down
Loading