Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minor css improvements #4735

Merged
merged 3 commits into from
Oct 25, 2024
Merged

Conversation

coalest
Copy link
Collaborator

@coalest coalest commented Oct 25, 2024

(Doesn't resolve any issue)

Description

These are all minor styling changes. I know this kind of thing is not a priority but what can I say, I got distracted.

Three small changes:

  1. Remove styling of <abbr> tags. These tags are used by the simple form gem to annotate required fields. It appears that the underlining was meant to be removed (or was removed at some point), but the AdminLTE css was overwriting it in when precompiled into application.css.
  2. In the edit distribution form, the radio buttons are misaligned in Firefox (but not Chrome), so I fixed it.
  3. When editing radio buttons, the text is sometimes green? It appears simple form/bootstrap is trying to mark them as valid, but in a way that doesn't make sense. For example on the edit organization screen, any radio button field marked yes will appear green, and those marked no will appear black. When I don't think a "No" response is less valid than a "Yes" response.

See screenshots below:

Type of change

Purely UI style changes.

How Has This Been Tested?

I tested the changes manually in Firefox and Chrome, but no specs were added. I can add some if needed, but not sure how much value would be added.

Screenshots

  1. Required field styling change. Note the underlining of the asterisks.
    Before:
    Screenshot from 2024-10-25 10-08-30
    After:
    Screenshot from 2024-10-25 10-10-38
  2. Edit distribution issue in Firefox. Note the "Pick up" radio button alignment.
    Before: Screenshot from 2024-10-25 10-12-36
    After: Screenshot from 2024-10-25 10-13-22
  3. Note how every input section that was marked "Yes" is in green.
    Before: Screenshot from 2024-10-25 10-06-41
    After: Screenshot from 2024-10-25 10-07-29

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These sound good to me. I don't think we need specs for these styling changes.

@cielf cielf merged commit 247c977 into rubyforgood:main Oct 25, 2024
11 checks passed
@coalest coalest deleted the minor-css-improvements branch October 25, 2024 13:42
Copy link
Contributor

@coalest: Your PR Minor css improvements is part of today's Human Essentials production release: 2024.10.27.
Thank you very much for your contribution!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants