Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: context precedence #27

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix: context precedence #27

merged 2 commits into from
Jul 25, 2024

Conversation

MoumitaM
Copy link
Contributor

Description of the change

Event-level context will have higher precedence over batch level. default context > event context > batch context

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@MoumitaM MoumitaM requested a review from saikumarrs July 25, 2024 11:18
saikumarrs
saikumarrs reviewed Jul 25, 2024
View reviewed changes
src/utils.rs Outdated Show resolved Hide resolved
saikumarrs
saikumarrs requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@saikumarrs saikumarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have any unit tests to support the library?

src/utils.rs Outdated Show resolved Hide resolved
src/utils.rs Outdated Show resolved Hide resolved
src/utils.rs Outdated Show resolved Hide resolved
@MoumitaM MoumitaM merged commit f2bb520 into develop Jul 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoumitaM @saikumarrs