Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

web: Support gamepad button input #18083

Merged
merged 1 commit into from
Jan 24, 2025
Merged

web: Support gamepad button input #18083

merged 1 commit into from
Jan 24, 2025

Conversation

evilpie
Copy link
Collaborator

@evilpie evilpie commented Sep 26, 2024 •
edited
Loading

Mostly just a proof of concept right now. This doesn't actually support defining the button to keycode mappings yet. I suspect we want to think a bit deeper about how that configuration would look like before adding it to the Ruffle API.

@evilpie evilpie added A-web Area: Web & Extensions T-feature Type: New Feature (that Flash doesn't have) A-input Area: Input handling and removed A-input Area: Input handling labels Sep 26, 2024
@evilpie evilpie force-pushed the gamepad-web branch 3 times, most recently from 920559e to 864848d Compare January 5, 2025 17:35
@evilpie
Copy link
Collaborator Author

evilpie commented Jan 5, 2025 •
edited
Loading

gamepadButtonMapping is now a new experimental option. I think in the future we might want to support multiple gamepads and also some handling for stick axis. Maybe it would even be better to name the option something like experimentalGamepadButtonMapping.

@evilpie evilpie force-pushed the gamepad-web branch 3 times, most recently from f8cff1f to a6db632 Compare January 5, 2025 19:01
@evilpie evilpie marked this pull request as ready for review January 5, 2025 19:05
@evilpie evilpie added input Issues relating to user input in Flash content waiting-on-review Waiting on review from a Ruffle team member labels Jan 5, 2025
@evilpie evilpie merged commit 2139373 into ruffle-rs:master Jan 24, 2025
22 checks passed
@Lord-McSweeney Lord-McSweeney removed the waiting-on-review Waiting on review from a Ruffle team member label Jan 25, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Lord-McSweeney Lord-McSweeney Lord-McSweeney approved these changes

Assignees
No one assigned
Labels
A-web Area: Web & Extensions input Issues relating to user input in Flash content newsworthy T-feature Type: New Feature (that Flash doesn't have)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evilpie @Lord-McSweeney @n0samu