Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow modulus in constant expressions #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow modulus in constant expressions #132

wants to merge 1 commit into from

Commits on Jul 20, 2023

  1. Allow modulus in constant expressions 

    Not sure if this was intentional, but I noticed `eval2(...)` will compile-time evaluate a modulus but `is_const_expr(...)` won't. This causes chibicc to try and compile some arrays as VLAs, which was causing problems for me. This change adds `ND_MOD` to the list of allowed constant expressions.

It's possible I'm missing something, but https://en.cppreference.com/w/c/language/constant_expression seems to imply that all numeric operators (including modulus) should be OK in constant expressions. And `ND_DIV` is already allowed in the function so it seems `ND_MOD` should be as well.
    @matthewsot
    matthewsot authored Jul 20, 2023
    Configuration menu
    Copy the full SHA
    afd9b06 View commit details
    Browse the repository at this point in the history