Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add falkordb vectorstore #16944

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

gkorland
Copy link
Contributor

Description

This pull request introduces support for FalkorDB as a vectorstore option in LlamaIndex. The changes include:

  • Integration code: Added new code in base.py to handle operations with Falkordb following the structure of other vectorstore integrations.

  • Testing: Included tests.py to verify the integration works as expecte

Fixes #16943

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Nov 13, 2024
@gkorland gkorland marked this pull request as draft November 13, 2024 21:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add support for FalkorDB vector indexing
3 participants