Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

replace docs reference #931

Merged
merged 2 commits into from
Aug 4, 2022
Merged

replace docs reference #931

merged 2 commits into from
Aug 4, 2022

Conversation

NitinAgg
Copy link
Collaborator

@NitinAgg NitinAgg commented Aug 4, 2022

Description

Safety checklist

  • This change is backwards compatible and safe to apply by existing users
  • This change will NOT lead to data loss
  • This change will NOT lead to downtime who already has an env/service setup

How has this change been tested, beside unit tests?

YOUR_ANSWER

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #931 (652347d) into main (ce5d57f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 652347d differs from pull request most recent head a82f4b8. Consider uploading reports for the commit a82f4b8 to get more accurate results

@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   72.81%   72.81%           
=======================================
  Files         118      118           
  Lines        7994     7994           
=======================================
  Hits         5821     5821           
  Misses       2173     2173           
Flag Coverage Δ
unittests 72.81% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
opta/cli.py 73.91% <ø> (ø)
opta/commands/deploy.py 79.36% <ø> (ø)
opta/commands/secret.py 80.00% <ø> (ø)
opta/commands/upgrade.py 67.64% <ø> (ø)
opta/layer.py 84.65% <ø> (ø)
opta/constants.py 100.00% <100.00%> (ø)
opta/core/terraform.py 61.95% <100.00%> (ø)
opta/core/upgrade.py 85.36% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@NitinAgg NitinAgg merged commit df008b8 into main Aug 4, 2022
@NitinAgg NitinAgg deleted the nitin/docs-ref branch August 4, 2022 18:22
NitinAgg added a commit that referenced this pull request Aug 4, 2022
NitinAgg added a commit that referenced this pull request Aug 4, 2022
* Revert "readme-fix"

This reverts commit 8c98209.

* Revert "replace docs reference (#931)"

This reverts commit df008b8.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant