chore: Remove dependency on multierror #5275
Merged
+20
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemassa
requested review from
GenPage,
nitrocode and
X-Guardian
and removed request for
a team
dosubot
bot
added
dependencies
Signed-off-by: Luke Massa <lukefrederickmassa@gmail.com>
lukemassa
force-pushed
the
remove_multierror
branch
from
a2c3f6b to
ef76f6b
Compare
lukemassa
force-pushed
the
remove_multierror
branch
from
d50b359 to
f4950fb
Compare
|
We believe there to be unrelated issues with the "synk" checks and are merging despite their failure. |
bub3n
pushed a commit
to bub3n/atlantis
that referenced
this pull request
Feb 3, 2025
Signed-off-by: Luke Massa <lukefrederickmassa@gmail.com> Signed-off-by: Petr Bubenik <petr.bubenik@drmax.eu>
1 task
bub3n
pushed a commit
to bub3n/atlantis
that referenced
this pull request
Feb 4, 2025
Signed-off-by: Luke Massa <lukefrederickmassa@gmail.com> Signed-off-by: Petr Bubenik <petr.bubenik@drmax.eu>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Replace hashicorp's multierror with functionality from the standard library. Also in the edited files, mostly to prevent import naming collisions, replaced pkg/errors with stdlib errors
why
While investigating #5269, I found a number of the more complicated usages of
pkg/errorswere due to https://github.com/hashicorp/go-multierror.Go 1.20 introduced
errors.Joinwhich essentially has the same functionality as multierror. Even hashicorp itself is working to switch to the stdlib: hashicorp/terraform-provider-aws#32140.This also cleans up some awkward logic to smooth over the mixed use of standard errors and multierrors.
tests
Ran unit tests.
references