Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update GuidanceLogitsProcessor to use llguidance bitmask functions #5

Open
wants to merge 2 commits into
base: llguidance-v0-integration
Choose a base branch
from
Open

Update GuidanceLogitsProcessor to use llguidance bitmask functions #5

wants to merge 2 commits into from

Conversation

JC1DA
Copy link

@JC1DA JC1DA commented Mar 11, 2025

Update GuidanceLogitsProcessor to use llguidance bitmask functions

@JC1DA
move grammar compilation to _get_serialized_grammar func
ec89c3e 
Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
@JC1DA JC1DA requested a review from russellb as a code owner March 11, 2025 23:32
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@JC1DA JC1DA changed the title move grammar compilation to _get_serialized_grammar func Update GuidanceLogitsProcessor to use llguidance bitmask functions Mar 11, 2025
russellb
russellb reviewed Mar 12, 2025
View reviewed changes
Copy link
Owner

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor comment. thanks!!

@russellb
Remove unused cached_grammars dict
e10d183 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@russellb russellb russellb left review comments

Assignees
No one assigned
Labels
structured-output
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JC1DA @russellb