Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Things to forward port from v1 to v2 #348

Open
1 of 4 tasks
rtfb opened this issue Apr 13, 2017 · 2 comments
Open
1 of 4 tasks

Things to forward port from v1 to v2 #348

rtfb opened this issue Apr 13, 2017 · 2 comments
Labels
v2

Comments

@rtfb
Copy link
Collaborator

rtfb commented Apr 13, 2017 •
edited
Loading

A tracking issue to mark stuff that needs forward porting from v1 to v2.

API-breaking (i.e. must be addressed before releasing v2):

  • No known issues

Other:
@rtfb rtfb added the v2 label Apr 13, 2017
@dmitshur dmitshur mentioned this issue Jun 20, 2017
Closed
@dmitshur dmitshur mentioned this issue Sep 18, 2017
Merged
@james-lawrence
Copy link

looks like this is done?

@dmitshur
Copy link
Collaborator

dmitshur commented Dec 23, 2018 •
edited
Loading

This isn't done; those are three v1 PRs that need to be ported to v2. I'll work on porting #352 now. Edit: It is done now, see PR #509.

dmitshur added a commit that referenced this issue Dec 23, 2018
@dmitshur
Document SanitizedAnchorName algorithm, copy implementation.
8cc535d 
The goal of this change is to reduce number of non-standard library
packages (repositories) that blackfriday imports (not counting imports
used only for tests) from 1 to 0, and in turn, reduce the cost of
importing blackfriday into other projects.

Do so by documenting the algorithm of SanitizedAnchorName, and include
a copy of the small function inside blackfriday itself. The same
functionality continues to be available in the original location,
github.com/shurcooL/sanitized_anchor_name.Create. It can be used by
existing users and those that look for a small package, and don't need
all of blackfriday functionality. Existing users of blackfriday can use
the new SanitizedAnchorName function directly and avoid an extra
package import.

This change is a port of PR #352 from v1 into v2.

Updates #348.
Updates #350.
@dmitshur dmitshur mentioned this issue Dec 23, 2018
Merged
dmitshur added a commit that referenced this issue Jan 20, 2019
@dmitshur
Document SanitizedAnchorName algorithm, copy implementation. (#509)
919b1f5 
The goal of this change is to reduce number of non-standard library
packages (repositories) that blackfriday imports (not counting imports
used only for tests) from 1 to 0, and in turn, reduce the cost of
importing blackfriday into other projects.

Do so by documenting the algorithm of SanitizedAnchorName, and include
a copy of the small function inside blackfriday itself. The same
functionality continues to be available in the original location,
github.com/shurcooL/sanitized_anchor_name.Create. It can be used by
existing users and those that look for a small package, and don't need
all of blackfriday functionality. Existing users of blackfriday can use
the new SanitizedAnchorName function directly and avoid an extra
package import.

This change is a port of PR #352 from v1 into v2.

Updates #348.
Updates #350.
@github-actions github-actions bot mentioned this issue Apr 10, 2022
Closed
@github-actions github-actions bot mentioned this issue Apr 17, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rtfb @dmitshur @james-lawrence