Fix bug with gathering list item lines #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of swallowing an empty line and then reintroducing it back again in certain cases, collect the list item body in an unaltered form and let the recursive parsing call sort things out. Fixes issue #228.
|
This is an awesome fix for blackfriday! 👏 I am surprised too. I suppose having more than 1 blank line in real world documents is pretty rare, but it wasn't correct even in that case (there was an extra blank line rendered). It's probably because most other Markdown renderers seem to have this bug too, so that might've been a deterrent for reporting this. I'm not closely familiar with implementation details of LGTM based on that. |
miekg
added a commit
to miekg/mmark
that referenced
this pull request
Dec 30, 2015
rtfb
added a commit
that referenced
this pull request
Dec 30, 2015
Fix bug with gathering list item lines
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This problem has been lurking since the very early days, apparently introduced with commit 583b3c5. Strange that nobody stumbled upon it for so long.
Instead of swallowing an empty line and then reintroducing it back again in certain cases, collect the list item body in an unaltered form and let the recursive parsing call sort things out.
Fixes issue #228.