Add Smartypants support for French Guillemets #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix looks good. Would you also be willing to forward port it to v2? The internals of Smartypants haven't changed much there, IIRC. |
No problem, I will do that in a separate PR. I created #380 to track/remind me of it. |
dmitshur
reviewed
Jul 27, 2017
smartypants.go
Outdated
| func smartypants(flags int) *smartypantsRenderer { | ||
| r := new(smartypantsRenderer) | ||
| addNbsp := flags&HTML_SMARTYPANTS_QUOTES_NBSP != 0 |
There was a problem hiding this comment.
Style nit, addNBSP, see https://golang.org/s/style#initialisms.
This commits adds flag `HTML_SMARTYPANTS_QUOTES_NBSP` which, when combined with `HTML_USE_SMARTYPANTS` will insert non-breaking spaces between the double quotes and the contained text. This is mostly relevant for use in French with `HTML_SMARTYPANTS_ANGLED_QUOTES`. It should not hurt existing code path in the performance department: ``` name old time/op new time/op delta SmartDoubleQuotes-4 2.58µs ± 1% 2.58µs ± 1% ~ (p=1.000 n=5+5) name old alloc/op new alloc/op delta SmartDoubleQuotes-4 5.27kB ± 0% 5.27kB ± 0% ~ (all samples are equal) name old allocs/op new allocs/op delta SmartDoubleQuotes-4 13.0 ± 0% 13.0 ± 0% ~ (all samples are equal) ``` Fixes #378
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds flag
HTML_SMARTYPANTS_QUOTES_NBSPwhich, when combined withHTML_USE_SMARTYPANTSwill insert non-breaking spaces between the double quotes and the contained text.This is mostly relevant for use in French with
HTML_SMARTYPANTS_ANGLED_QUOTES.It should not hurt existing code path in the performance department:
Fixes #378