Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

node: The default feature is a footgun #40

Closed
tcharding opened this issue Jan 21, 2025 · 2 comments · Fixed by #45
Closed

node: The default feature is a footgun #40

tcharding opened this issue Jan 21, 2025 · 2 comments · Fixed by #45

Comments

@tcharding
Copy link
Member

corepc-node has a default feature 28_0 - this is an unnecessary footgun because it overides the version supplied in another feature e.g., cargo test --features=25_2 runs tests using Core v28 still because default features are enabled.

@tcharding
Copy link
Member Author

Found here: RCasatta/electrsd#89 (comment)

@apoelstra
Copy link
Member

Good catch. I guess we should disable all features by default and have a compile error telling users that they need to enable one.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants