change bitcoind -> corepc_node

[RCasatta]

#88

[RCasatta]

will investigate the errors another day... Maybe @tcharding could give an hint in the meantime

[tcharding]

I imagined one would just alias back to bitcoind

use corepc_node as bitcoind;

[RCasatta]

yeah or rename directly at Cargo.toml level... I just prefer to have it explicit so that looking at the code you cannot mistakely think it's still the other crate

[tcharding]

Sweeet, I think there are multiple problems. One is easy and one I thought I fixed - let me look more.

The easy one is that how I added a default feature in corepc-node is a foot gun, if default features are enabled corepc-node uses v28. So to correctly handle features here the dependency has to be

corepc-node = { version = "0.5.0", default-features = false }

The second one is to do with how Bitcoin Core v28 binds to ports now, something to do with the Tor changes. I thought I fixed it but let me look some more.

[tcharding]

Ouch, I did "fix" it. Using #[cfg(not(feature = "28_0"))]

Created issue: rust-bitcoin/corepc#41

[RCasatta]

Thanks @tcharding removing default features fixed the issues...

@MaxFangX I am going to merge/release tomorrow or so

[MaxFangX]

Thank you @RCasatta !

[tcharding]

Oh I'm surprised CI passes using Core v28 - I thought I hit the "cannot run units tests in parallel because of port binding" issue yesterday when running them.

[MaxFangX]

EDIT: Should be -bind=<addr> instead of -bind=<port>

The second one is to do with how Bitcoin Core v28 binds to ports now, something to do with the Tor changes. I thought I fixed it but let me look some more.

I recently had to muck around with this trying to run multiple bitcoind regtest instances on one machine. I don't know what your exact problem is, but in our case setting P2P::Yes still leaves port 18445=onion unchanged meaning two instances will both try to bind to 18445. I worked around this by setting -bind=<addr>. Maybe that will help in your case. @tcharding

Our code which uses electrsd, on latest released version:

// Configure bitcoind
let bitcoind_exe_path = std::env::var("BITCOIND_EXE")
    .or_else(|_| bitcoind::downloaded_exe_path())
    .expect("Didn't specify oneof `$BITCOIND_EXE` or bitcoind version in feature flags");
debug!(%bitcoind_exe_path);

let mut bitcoind_conf = bitcoind::Conf::default();
bitcoind_conf.staticdir = data_dir.as_ref().map(|d| d.join("bitcoind"));

// In bitcoind 28.0 (our current nix packaged version), `-bind` defaults
// to `127.0.0.1:18445=onion` for regtest (see `bitcoind -help`).
// Setting `bitcoind::Conf::p2p` to `P2P::Yes` sets the `-port=<port>`
// CLI arg, but it still leaves a listener at `18445=onion`, which
// causes bind conflicts when running multiple bitcoind instances. To
// overcome this, we set `-bind=[::1]:<port>`, which overrides anything
// set with `-port`. Unfortunately, setting `P2P::No` sets `-listen=0`
// which is incompatible with `-bind`. So we use `P2P::Yes` which sets
// `-listen=1` but emits a confusing unreachable p2p port in the logs.
//
// One bonus of all this is now we can specify which port the p2p
// listener should bind to. For now, we just use an ephemeral port.
let bitcoind_p2p_port =
    get_ephemeral_port().expect("Couldn't get ephemeral port");
let bitcoind_p2p_addr =
    SocketAddr::from(([0, 0, 0, 0, 0, 0, 0, 1], bitcoind_p2p_port));
info!(%bitcoind_p2p_addr);
let bind_arg = format!("-bind={bitcoind_p2p_addr}");
bitcoind_conf.args.push(&bind_arg);
bitcoind_conf.p2p = P2P::Yes;

// Init bitcoind
let bitcoind = BitcoinD::with_conf(bitcoind_exe_path, &bitcoind_conf)
    .expect("Failed to init bitcoind");

Full implementation of our wrapper here: https://gist.github.com/MaxFangX/a2c42179915b1c61f168db86f121d90c

[tcharding]

Sweeeet, legendary @MaxFangX. Thanks man