Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Release tracking PR: v0.6.0 #49

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

tcharding
Copy link
Member

@tcharding tcharding commented Jan 23, 2025

Draft till #53 goes in.

In preparation for release of all three crates add changelog entries, bump the version number, and update the lock files.

@tcharding tcharding marked this pull request as draft January 23, 2025 01:44
@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch 2 times, most recently from f22905c to ac517db Compare February 4, 2025 22:42
@tcharding tcharding marked this pull request as ready for review February 4, 2025 22:42
@tcharding tcharding marked this pull request as draft February 5, 2025 04:55
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ac517db; successfully ran local tests

@tcharding tcharding force-pushed the 01-23-release-0.6.0 branch 3 times, most recently from 0490471 to a55fe9b Compare February 6, 2025 22:45
rustdoc expects to be on an item. Make the docs on `tmpdir` conform to
rustdoc format.
The `getbalances` RPC method is currently being feature guarded on
`not(download)`. I'm not sure why but it seems unnecessary.
Currently we do not include the `node` crate in the workspace because
`run_task` did not support testing it.

However `run_task` is patched in

 rust-bitcoin/rust-bitcoin-maintainer-tools#19

So we can use it now.

Include `node` in the workspace. Configure it to work with the newly
patched `run_task`. Add a `extra_tests.sh` script that runs the `node`
tests.

In order to get MSRV building we make all deps use `default-features =
false` then explicitly enable just what we need.
Add a brief readme file, point at `cargo run -- --help` and also at the
docs we already wrote in `types/README.md`.
In preparation for release bump the version numbers of `types`,
`client`, and `node` to `0.6.0`.

Add changelog entries to each and update the lock files.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants