Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement GetKey for KeyMap #709

Open
LLFourn opened this issue Jul 17, 2024 · 2 comments · May be fixed by #765
Open

Implement GetKey for KeyMap #709

LLFourn opened this issue Jul 17, 2024 · 2 comments · May be fixed by #765

Comments

@LLFourn
Copy link
Contributor

LLFourn commented Jul 17, 2024

See the trait here:

https://docs.rs/bitcoin/latest/bitcoin/psbt/trait.GetKey.html

I think it'd make sense if KeyMap (or something like it) implemented this trait so you could sign PSBTs with the secret keys extracted from a private descriptor.
@apoelstra
Copy link
Member

Oo, neat. Concept ACK. May be a little bit because we are rejigging the relationship between rust-bitcoin and rust-miniscript and I'm unsure what happens to PSBT during that transition.

@tcharding
Copy link
Member

Once bitcoin depends on miniscript hopefully we move psbt_v2 into bitcoin but that shouldn't effect this issue, we can solve this in either miniscript::psbt and port it or in psbt_v2 if we have done the move already. (psbt_v2 contains all the code from psbt::miniscript anyways.)

tcharding added a commit to tcharding/rust-miniscript that referenced this issue Oct 29, 2024
@tcharding
Implement GetKey for KeyMap
17a9068 
Create a `KeyMay` type to replace the current `BTreeMap` alias and
implement `bitcoin::psbt::GetKey` for it.

Close: rust-bitcoin#709
@tcharding tcharding linked a pull request Oct 29, 2024 that will close this issue
Open
tcharding added a commit to tcharding/rust-miniscript that referenced this issue Oct 29, 2024
@tcharding
Implement GetKey for KeyMap
ba5b2bf 
Create a `KeyMay` type to replace the current `BTreeMap` alias and
implement `bitcoin::psbt::GetKey` for it.

Close: rust-bitcoin#709
tcharding added a commit to tcharding/rust-miniscript that referenced this issue Oct 29, 2024
@tcharding
Implement GetKey for KeyMap
4a3bd7e 
Create a `KeyMay` type to replace the current `BTreeMap` alias and
implement `bitcoin::psbt::GetKey` for it.

Close: rust-bitcoin#709
tcharding added a commit to tcharding/rust-miniscript that referenced this issue Oct 29, 2024
@tcharding
Implement GetKey for KeyMap
81b4923 
Create a `KeyMay` type to replace the current `BTreeMap` alias and
implement `bitcoin::psbt::GetKey` for it.

Close: rust-bitcoin#709
tcharding added a commit to tcharding/rust-miniscript that referenced this issue Oct 29, 2024
@tcharding
Implement GetKey for KeyMap
00342a1 
Create a `KeyMay` type to replace the current `BTreeMap` alias and
implement `bitcoin::psbt::GetKey` for it.

Close: rust-bitcoin#709
tcharding added a commit to tcharding/rust-miniscript that referenced this issue Dec 12, 2024
@tcharding
Implement GetKey for KeyMap
4920626 
Create a `KeyMay` type to replace the current `BTreeMap` alias and
implement `bitcoin::psbt::GetKey` for it.

Close: rust-bitcoin#709
tcharding added a commit to tcharding/rust-miniscript that referenced this issue Dec 12, 2024
@tcharding
Implement GetKey for KeyMap
a97c37a 
Create a `KeyMay` type to replace the current `BTreeMap` alias and
implement `bitcoin::psbt::GetKey` for it.

Close: rust-bitcoin#709
tcharding added a commit to tcharding/rust-miniscript that referenced this issue Dec 13, 2024
@tcharding
Implement GetKey for KeyMap
d2c954a 
Create a `KeyMay` type to replace the current `BTreeMap` alias and
implement `bitcoin::psbt::GetKey` for it.

Close: rust-bitcoin#709
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement GetKey for KeyMap tcharding/rust-miniscript
3 participants
@apoelstra @LLFourn @tcharding